Skip to content

Conversation

@kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented May 6, 2025

Description

Update cdt-lsp to v3.1.0

Fixes # (IEP-1526)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Install the PR build on the eclipse cdt 2025-03 and espressif-ide v3.3.0

Test Configuration:

  • ESP-IDF Version: master
  • OS (Windows,Linux and macOS): macOS

Dependent components impacted by this PR:

  • Update site

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Chores
    • Updated the repository URL for the Eclipse CDT LSP feature group to version 3.1.

@coderabbitai
Copy link

coderabbitai bot commented May 6, 2025

Walkthrough

The repository URL for the Eclipse CDT LSP feature group in the target configuration has been updated from version 3.0 to version 3.1. No other units or version numbers were changed in this update.

Changes

File(s) Change Summary
releng/com.espressif.idf.target/com.espressif.idf.target.target Updated the Eclipse CDT LSP feature group repository URL from 3.0 to 3.1

Possibly related PRs

Suggested reviewers

  • alirana01
  • sigmaaa

Poem

A hop, a skip, a version jump,
CDT LSP gets a gentle bump.
From three-point-oh to three-point-one,
The target file’s update is done.
🐇✨
With URLs fresh and code aligned,
The plugin’s path is well-defined!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a59959 and c4af45a.

📒 Files selected for processing (1)
  • releng/com.espressif.idf.target/com.espressif.idf.target.target (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build
  • GitHub Check: build_macos
🔇 Additional comments (2)
releng/com.espressif.idf.target/com.espressif.idf.target.target (2)

99-99: Approved: CDT LSP repository updated to v3.1.0
The URL change correctly upgrades the CDT LSP feature group from 3.0 to 3.1.0.


99-99:

Details

✅ Verification successful

Check update site URL accessibility
Please verify that the new CDT LSP 3.1.0 repository URL is correct and reachable.


🏁 Script executed:

#!/usr/bin/env bash
# Verify HTTP 200 response for the new CDT LSP update site
curl -s -o /dev/null -w "%{http_code}" \
  https://download.eclipse.org/tools/cdt/releases/cdt-lsp-3.1/cdt-lsp-3.1.0/ \
| grep -q '^200$' && echo "✅ OK" || echo "❌ FAILED"

Length of output: 152


CDT LSP 3.1.0 Update Site URL Verified
The repository URL in releng/com.espressif.idf.target/com.espressif.idf.target.target (line 99) returns HTTP 200 as expected. No further action required. ✅


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AndriiFilippov
Copy link
Collaborator

@kolipakakondal hi !

Tested under:
OS - Windows 11
Eclipse 25-03
ESP-IDF: master

installed on latest Eclipse -> created and built project - able to build / flash / monitor / debug BUT after build see this error in error logs:

logs.log

@kolipakakondal
Copy link
Collaborator Author

As discussed, as it's not changing the content of .clangd, that should be fine. Looks like other process ClangdCompilationDatabaseSetterBase was trying to modify in the file system after the build.

@kolipakakondal kolipakakondal merged commit 3e7c679 into master May 6, 2025
2 of 4 checks passed
@kolipakakondal kolipakakondal deleted the IEP-1526 branch May 6, 2025 12:20
@coderabbitai coderabbitai bot mentioned this pull request Jan 13, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants