Example doesn't compile due to implicit declaration of functions

[johseg]

The error:

[912/920] Building C object esp-idf/esp32-camera-2.0.3/CMakeFiles/__idf_esp32-camera-2.0.3.dir/target/esp32/ll_cam.c.objFAILED: esp-idf/esp32-camera-2.0.3/CMakeFiles/__idf_esp32-camera-2.0.3.dir/target/esp32/ll_cam.c.obj
/home/johannes/.espressif/tools/xtensa-esp32-elf/esp-12.2.0_20230208/xtensa-esp32-elf/bin/xtensa-esp32-elf-gcc -DESP_PLATFORM -DIDF_VER=\"v5.2-dev-544-g54576b7528\" -DSOC_MMU_PAGE_SIZE=CONFIG_MMU_PAGE_SIZE -D_GNU_SOURCE -D_POSIX_READER_WRITER_LOCKS -I/home/johannes/repos/esp-idf/esp-idf-v5.0.2/components/esp32-camera-2.0.3/examples/build/config -I/home/johannes/repos/esp-idf/esp-idf-v5.0.2/components/esp32-camera-2.0.3/driver/include -I/home/johannes/repos/esp-idf/esp-idf-v5.0.2/components/esp32-camera-2.0.3/conversions/include -I/home/johannes/repos/esp-idf/esp-idf-v5.0.2/components/esp32-camera-2.0.3/conversions/private_include -I/home/johannes/repos/esp-idf/esp-idf-v5.0.2/components/esp32-camera-2.0.3/driver/private_include -I/home/johannes/repos/esp-idf/esp-idf-v5.0.2/components/esp32-camera-2.0.3/sensors/private_include -I/home/johannes/repos/esp-idf/esp-idf-v5.0.2/components/esp32-camera-2.0.3/target/private_include -I/home/johannes/repos/edf/esp-idf/components/newlib/platform_include -I/home/johannes/repos/edf/esp-idf/components/freertos/config/include -I/home/johannes/repos/edf/esp-idf/components/freertos/config/include/freertos -I/home/johannes/repos/edf/esp-idf/components/freertos/config/xtensa/include -I/home/johannes/repos/edf/esp-idf/components/freertos/FreeRTOS-Kernel/include -I/home/johannes/repos/edf/esp-idf/components/freertos/FreeRTOS-Kernel/portable/xtensa/include -I/home/johannes/repos/edf/esp-idf/components/freertos/FreeRTOS-Kernel/portable/xtensa/include/freertos -I/home/johannes/repos/edf/esp-idf/components/freertos/esp_additions/include -I/home/johannes/repos/edf/esp-idf/components/esp_hw_support/include -I/home/johannes/repos/edf/esp-idf/components/esp_hw_support/include/soc -I/home/johannes/repos/edf/esp-idf/components/esp_hw_support/include/soc/esp32 -I/home/johannes/repos/edf/esp-idf/components/esp_hw_support/port/esp32/. -I/home/johannes/repos/edf/esp-idf/components/esp_hw_support/port/esp32/private_include -I/home/johannes/repos/edf/esp-idf/components/heap/include -I/home/johannes/repos/edf/esp-idf/components/log/include -I/home/johannes/repos/edf/esp-idf/components/soc/include -I/home/johannes/repos/edf/esp-idf/components/soc/esp32 -I/home/johannes/repos/edf/esp-idf/components/soc/esp32/include -I/home/johannes/repos/edf/esp-idf/components/hal/esp32/include -I/home/johannes/repos/edf/esp-idf/components/hal/include -I/home/johannes/repos/edf/esp-idf/components/hal/platform_port/include -I/home/johannes/repos/edf/esp-idf/components/esp_rom/include -I/home/johannes/repos/edf/esp-idf/components/esp_rom/include/esp32 -I/home/johannes/repos/edf/esp-idf/components/esp_rom/esp32 -I/home/johannes/repos/edf/esp-idf/components/esp_common/include -I/home/johannes/repos/edf/esp-idf/components/esp_system/include -I/home/johannes/repos/edf/esp-idf/components/esp_system/port/soc -I/home/johannes/repos/edf/esp-idf/components/esp_system/port/include/private -I/home/johannes/repos/edf/esp-idf/components/xtensa/esp32/include -I/home/johannes/repos/edf/esp-idf/components/xtensa/include -I/home/johannes/repos/edf/esp-idf/components/xtensa/deprecated_include -I/home/johannes/repos/edf/esp-idf/components/lwip/include -I/home/johannes/repos/edf/esp-idf/components/lwip/include/apps -I/home/johannes/repos/edf/esp-idf/components/lwip/include/apps/sntp -I/home/johannes/repos/edf/esp-idf/components/lwip/lwip/src/include -I/home/johannes/repos/edf/esp-idf/components/lwip/port/include -I/home/johannes/repos/edf/esp-idf/components/lwip/port/freertos/include -I/home/johannes/repos/edf/esp-idf/components/lwip/port/esp32xx/include -I/home/johannes/repos/edf/esp-idf/components/lwip/port/esp32xx/include/arch -I/home/johannes/repos/edf/esp-idf/components/lwip/port/esp32xx/include/sys -I/home/johannes/repos/edf/esp-idf/components/driver/include -I/home/johannes/repos/edf/esp-idf/components/driver/deprecated -I/home/johannes/repos/edf/esp-idf/components/driver/analog_comparator/include -I/home/johannes/repos/edf/esp-idf/components/driver/dac/include -I/home/johannes/repos/edf/esp-idf/components/driver/gpio/include -I/home/johannes/repos/edf/esp-idf/components/driver/gptimer/include -I/home/johannes/repos/edf/esp-idf/components/driver/i2c/include -I/home/johannes/repos/edf/esp-idf/components/driver/i2s/include -I/home/johannes/repos/edf/esp-idf/components/driver/ledc/include -I/home/johannes/repos/edf/esp-idf/components/driver/mcpwm/include -I/home/johannes/repos/edf/esp-idf/components/driver/parlio/include -I/home/johannes/repos/edf/esp-idf/components/driver/pcnt/include -I/home/johannes/repos/edf/esp-idf/components/driver/rmt/include -I/home/johannes/repos/edf/esp-idf/components/driver/sdio_slave/include -I/home/johannes/repos/edf/esp-idf/components/driver/sdmmc/include -I/home/johannes/repos/edf/esp-idf/components/driver/sigma_delta/include -I/home/johannes/repos/edf/esp-idf/components/driver/spi/include -I/home/johannes/repos/edf/esp-idf/components/driver/temperature_sensor/include -I/home/johannes/repos/edf/esp-idf/components/driver/touch_sensor/include -I/home/johannes/repos/edf/esp-idf/components/driver/twai/include -I/home/johannes/repos/edf/esp-idf/components/driver/uart/include -I/home/johannes/repos/edf/esp-idf/components/driver/usb_serial_jtag/include -I/home/johannes/repos/edf/esp-idf/components/driver/touch_sensor/esp32/include -I/home/johannes/repos/edf/esp-idf/components/esp_pm/include -I/home/johannes/repos/edf/esp-idf/components/esp_ringbuf/include -I/home/johannes/repos/edf/esp-idf/components/nvs_flash/include -I/home/johannes/repos/edf/esp-idf/components/spi_flash/include -I/home/johannes/repos/edf/esp-idf/components/esp_partition/include -I/home/johannes/repos/edf/esp-idf/components/esp_timer/include -mlongcalls -Wno-frame-address  -fdiagnostics-color=always -fdiagnostics-color=always -ffunction-sections -fdata-sections -Wall -Werror=all -Wno-error=unused-function -Wno-error=unused-variable -Wno-error=unused-but-set-variable -Wno-error=deprecated-declarations -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-enum-conversion -gdwarf-4 -ggdb -mfix-esp32-psram-cache-issue -mfix-esp32-psram-cache-strategy=memw -Og -fmacro-prefix-map=/home/johannes/repos/esp-idf/esp-idf-v5.0.2/components/esp32-camera-2.0.3/examples=. -fmacro-prefix-map=/home/johannes/repos/edf/esp-idf=/IDF -fstrict-volatile-bitfields -fno-jump-tables -fno-tree-switch-conversion -std=gnu17 -Wno-old-style-declaration -MD -MT esp-idf/esp32-camera-2.0.3/CMakeFiles/__idf_esp32-camera-2.0.3.dir/target/esp32/ll_cam.c.obj -MF esp-idf/esp32-camera-2.0.3/CMakeFiles/__idf_esp32-camera-2.0.3.dir/target/esp32/ll_cam.c.obj.d -o esp-idf/esp32-camera-2.0.3/CMakeFiles/__idf_esp32-camera-2.0.3.dir/target/esp32/ll_cam.c.obj -c /home/johannes/repos/esp-idf/esp-idf-v5.0.2/components/esp32-camera-2.0.3/target/esp32/ll_cam.c
/home/johannes/repos/esp-idf/esp-idf-v5.0.2/components/esp32-camera-2.0.3/target/esp32/ll_cam.c: In function 'll_cam_vsync_isr':
/home/johannes/repos/esp-idf/esp-idf-v5.0.2/components/esp32-camera-2.0.3/target/esp32/ll_cam.c:208:5: error: implicit declaration of function 'ets_delay_us'; did you mean 'esp_rom_delay_us'? [-Werror=implicit-function-declaration]
  208 |     ets_delay_us(1);
      |     ^~~~~~~~~~~~
      |     esp_rom_delay_us
cc1: some warnings being treated as errors
[913/920] Linking C static library esp-idf/wifi_provisioning/libwifi_provisioning.aninja: build stopped: subcommand failed.

I tried a couple of combinations:

• esp-idf-v5.0.2 + esp32-camera-2.0.[1-4] and master
• esp-idf-v4.3.5 + esp32-camera-2.0.[1-4] and master

No combination works. I found #286, but no real solution is provided

[jjsch-dev]

@johseg, I have the same problem, with esp32-s3 it compiles successfully, but not for standard esp32. Comparing the files /esp-idf/components/esp32-camera/target/esp32s3/ll_cam.c and /esp-idf/components/esp32-camera/target/esp32/ll_cam.c I found out that they change this function for the esp32-s3 but not for the esp32.

esp32-S3

#if (ESP_IDF_VERSION_MAJOR >= 5)
#include "soc/gpio_sig_map.h"
#include "soc/gpio_periph.h"
#include "soc/io_mux_reg.h"
#define gpio_matrix_in(a,b,c) esp_rom_gpio_connect_in_signal(a,b,c)
#define gpio_matrix_out(a,b,c,d) esp_rom_gpio_connect_out_signal(a,b,c,d)
#define ets_delay_us(a) esp_rom_delay_us(a)
#endif

esp32

#if (ESP_IDF_VERSION_MAJOR >= 4) && (ESP_IDF_VERSION_MINOR > 1)
#include "hal/gpio_ll.h"
#else
#include "soc/gpio_periph.h"
#define esp_rom_delay_us ets_delay_us

......

#if (ESP_IDF_VERSION_MAJOR >= 5)
#define GPIO_PIN_INTR_POSEDGE GPIO_INTR_POSEDGE
#define GPIO_PIN_INTR_NEGEDGE GPIO_INTR_NEGEDGE
#define gpio_matrix_in(a,b,c) esp_rom_gpio_connect_in_signal(a,b,c)
#endif

I change the esp32 to this:

#if (ESP_IDF_VERSION_MAJOR >= 5)
#define GPIO_PIN_INTR_POSEDGE GPIO_INTR_POSEDGE
#define GPIO_PIN_INTR_NEGEDGE GPIO_INTR_NEGEDGE
#define gpio_matrix_in(a,b,c) esp_rom_gpio_connect_in_signal(a,b,c)
#define ets_delay_us esp_rom_delay_us
#endif

[johseg]

that solves my problem, thank you! Keeping the issue open in case the maintainers want to add this to the repo

[jjsch-dev]

@johseg, thanks for the comment, and if you use the IDF version 5.2 you will have a problem with the clock:

camera_xclk: ledc_timer_config failed, rc=103

So I made the #539 pull request that fix both problems.

[jjsch-dev]

@johseg , use #542 because the old one fails the test with all IDF versions, and now I fixed it and it does.

[github-actions]

This issue appears to be stale. Please close it if its no longer valid.

[adokitkat]

This is still a problem (using esp-who)... The issue should be open.

[igrr]

esp-who includes a rather old commit of esp32-camera which is not compatible with IDF V5.x.

[jjsch-dev]

@adokitkat / @igrr, I'll try to make time this week to compile esp-who with master (5.2) and upload the fixed code.