Skip to content

Add a define into sdkconfig.h that shows the exact idf commit of build #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2019
Merged

Add a define into sdkconfig.h that shows the exact idf commit of build #2

merged 2 commits into from
Sep 22, 2019

Conversation

lbernstone
Copy link
Contributor

I expect there is some discussion of whether this is the appropriate place to put this, but having an auto-generated versioning will be very helpful for troubleshooting.

@me-no-dev
Copy link
Member

how about you get the branch too?

@lbernstone
Copy link
Contributor Author

lbernstone commented Sep 21, 2019

Isn't that available from esp_get_idf_version?
Actually, it includes the git version as well. Why is it that the current version shown in there is not available for checkout? backporting?

@me-no-dev
Copy link
Member

yes, that is the reason why I asked for the branch, since we will be tracking branches and not master. IDF_VER is more of a compiled text of some of that

@me-no-dev me-no-dev merged commit 381ced5 into espressif:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants