fix(websocket): Fix websocket client race on abort and memory leak(IDFGH-16555) #924
+97
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes critical memory leaks and crashes in the ESP WebSocket client that occur during reconnection scenarios(CONFIG_ESP_WS_CLIENT_SEPARATE_TX_LOCK = y).
Changes Made:
esp_websocket_client_abort_connection()to prevent double-closeesp_websocket_client_task()before dispatchingWEBSOCKET_EVENT_CONNECTEDerrormsg_bufferinesp_websocket_client_abort_connection()when client disconnectsclient->transport_listimmediately inesp_websocket_client_stop()ws_close()functionRelated
#898
Checklist
Before submitting a Pull Request, please ensure the following: