Skip to content

[mdns]: Fixes clang-tidy warnings #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2025
Merged

[mdns]: Fixes clang-tidy warnings #732

merged 4 commits into from
Jan 20, 2025

Conversation

david-cermak
Copy link
Collaborator

@david-cermak david-cermak self-assigned this Jan 13, 2025
@david-cermak david-cermak mentioned this pull request Jan 15, 2025
Merged
@david-cermak david-cermak force-pushed the fix/mdns_clangtiy_warns branch from ddb4b36 to e37b8a6 Compare January 15, 2025 11:29
@david-cermak
Copy link
Collaborator Author

@zwx1995esp PTAL, too

zwx1995esp
zwx1995esp approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@zwx1995esp zwx1995esp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, LGTM overall.

@david-cermak
fix(mdns): Fix potential null derefernce in _mdns_execute_action()
f5be2f4 
We did check for null-deref before checking 'a->type', but contol
continues and passes potential null-ptr to the processing function
_mdns_execute_action()
Fixed by asserting action != NULL, since it is an invalid state which
should never happen.
@david-cermak
fix(mdns): Fix name mangling not to use strcpy()
99b54ac 
Since it was flagged by clang-tidy as insecture API
@david-cermak
fix(mdns): Remove dead store to arg variable shared
e838bf0 
Fixing: warning: Value stored to 'shared' is never read [clang-analyzer-deadcode.DeadStores]
@david-cermak
fix(mdns): Fix zero-sized VLA clang-tidy warnings
196198e 
and some minor leaks in creation of browse results
@david-cermak david-cermak force-pushed the fix/mdns_clangtiy_warns branch from e37b8a6 to 196198e Compare January 15, 2025 13:24
@david-cermak david-cermak merged commit 93f7721 into espressif:master Jan 20, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euripedesrocha euripedesrocha euripedesrocha approved these changes

@zwx1995esp zwx1995esp zwx1995esp approved these changes

Assignees

@david-cermak david-cermak

Labels
mdns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-cermak @euripedesrocha @zwx1995esp