Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sock-utils] Fix potential macro conflict #720

Merged

Conversation

david-cermak
Copy link
Collaborator

Some macros could be defined already in standard headers (depending on IDF and compiler version).
Need to pre-include the official headers (since the macros are defined unconditionally).

@david-cermak david-cermak self-assigned this Dec 20, 2024
@kostaond kostaond self-requested a review December 20, 2024 13:44
Copy link
Collaborator

@kostaond kostaond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@david-cermak david-cermak force-pushed the fix/sock_utils_define_conflict branch 2 times, most recently from 9a434c9 to 148b57e Compare December 20, 2024 14:32
@david-cermak david-cermak force-pushed the fix/sock_utils_define_conflict branch from 148b57e to 0499ed9 Compare December 20, 2024 14:41
@david-cermak david-cermak merged commit b4cb8f8 into espressif:master Dec 20, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants