Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CONSOLE_USB_CDC and CONSOLE_USB_SERIAL_JTAG in modem_console example. (IDFGH-13937) #675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morgana2313
Copy link

Description

Added support for CONFIG_ESP_CONSOLE_USB_CDC and CONFIG_ESP_CONSOLE_USB_SERIAL_JTAG

added support for CONSOLE_USB_CDC and CONSOLE_USB_SERIAL_JTAG to modem_console example.

Related

As requested in #669 (comment) by @david-cermak .

Testing

Tested on an ESP32-s3 with a SIM 7670G.

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 24, 2024
@github-actions github-actions bot changed the title Support for CONSOLE_USB_CDC and CONSOLE_USB_SERIAL_JTAG in modem_console example. Support for CONSOLE_USB_CDC and CONSOLE_USB_SERIAL_JTAG in modem_console example. (IDFGH-13937) Oct 24, 2024
@david-cermak david-cermak self-assigned this Oct 24, 2024
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@david-cermak
Copy link
Collaborator

@morgana2313 Just please update the commit message per: https://github.com/espressif/esp-protocols/blob/master/CONTRIBUTING.md#submitting-a-pr
(for example:

feat(modem): Updated console example to support other console types

@morgana2313 morgana2313 reopened this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants