fix(modem): Add asserts and params error checks on create path - #1119
Open
david-cermak wants to merge 1 commit into
Open
fix(modem): Add asserts and params error checks on create path#1119david-cermak wants to merge 1 commit into
david-cermak wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #1102
Note
Low Risk
Small guardrails on creation only; behavior for valid callers is unchanged and invalid null args now fail safely instead of undefined behavior.
Overview
Adds defensive null-pointer validation on modem initialization so invalid callers fail early instead of dereferencing null configs or DTE handles.
On the C++ factory path,
create_vfs_dte,create_uart_dte, and sharedcreate_modem_dcenow useESP_MODEM_THROW_IF_FALSEfor nulldte/dceconfig and nulldtebefore building terminals or DCE instances (still surfaced asnullptrviaTRY_CATCH_RET_NULLwhen exceptions are enabled).On the C API,
esp_modem_new_devreturnsnullptrimmediately ifdte_configordce_configis null, before allocating the wrapper or calling into UART DTE creation.Reviewed by Cursor Bugbot for commit 5a435de. Bugbot is set up for automated code reviews on this repo. Configure here.