feat(libsrtp): bump submodule for mbedTLS 4 support; allow IDF v6.0 - #1114
Open
vikramdattu wants to merge 1 commit into
Open
feat(libsrtp): bump submodule for mbedTLS 4 support; allow IDF v6.0#1114vikramdattu wants to merge 1 commit into
vikramdattu wants to merge 1 commit into
Conversation
- Bump libsrtp submodule v2.8.0 (24b3bf8) -> 2_x_dev d33b8ff, the merge of cisco/libsrtp#813 (mbedTLS 4 / PSA Crypto support). The adapters self-select on MBEDTLS_VERSION_MAJOR, so mbedTLS 3 (IDF v5.x) paths are unchanged. - Drop the idf '<6' cap from idf_component.yml; component version 2.8.0 -> 2.8.0~1. - CI: build get_started + test_apps on release-v6.0 too. host_test stays on v5.x: the IDF v6 linux target fails to link PSA apps (libtfpsacrypto.a needs mbedtls_ms_time / esp_mbedtls_mem_* from archives earlier on the link line) - an IDF-side ordering issue, independent of libsrtp. Verified locally: test_apps builds clean for esp32 on IDF v6.0.2 (mbedTLS 4.1.0); the v6 linux host_test link failure reproduces with IDF's own tf-psa-crypto references only.
Contributor
Author
|
@david-cermak PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2.8.0release tag (24b3bf8) to2_x_devHEADd33b8ff— the merge of mbedTLS 4 / PSA Crypto support on 2_x_dev cisco/libsrtp#813, which adds mbedTLS 4 / PSA Crypto support to the 2.x mbedTLS adapters. The adapters self-select onMBEDTLS_VERSION_MAJOR, so mbedTLS 3 (IDF v5.x) code paths are untouched.idf <6cap fromidf_component.yml— this was gated on exactly this upstream work (the manifest comment referenced mbedTLS 4 support on 2_x_dev — plans? cisco/libsrtp#812). Component version2.8.0→2.8.0~1.get_started+test_appson release-v6.0 in addition to v5.4/v5.5.Verification
test_appsbuilds clean on IDF v6.0.2 (target esp32, mbedTLS 4.1.0) — full link, exit 0.Notes
libtfpsacrypto.areferencesmbedtls_ms_time/esp_mbedtls_mem_*that live in archives earlier on the link line (static archive ordering, IDF-side; reproduced with IDF's own libs, independent of libsrtp)..build-test-rules.ymldocuments this next to the disable rule.Note
Medium Risk
Touches crypto/SRTP integration and moves off a release tag to a dev-branch commit, though scope is mostly dependency pins, CI matrix, and manifest comments rather than new port logic.
Overview
Enables ESP-IDF v6 for the libsrtp component by advancing the upstream submodule from the v2.8.0 tag to
2_x_devcommitd33b8ff, which includes mbedTLS 4 / PSA Crypto adapters (cisco/libsrtp#813) that pick mbedTLS 3 vs 4 at compile time.Dependency and packaging:
idf_component.ymlchanges fromidf: ">=5.4,<6"to>=5.4, with component version2.8.0~1and SBOM metadata updated to the new pin.CI / build rules: The libsrtp workflow matrix adds
release-v6.0forget_startedandtest_apps..build-test-rules.ymlremoves the blanket “disable IDF v6” rules for those apps and documents v6 as supported;host_testremains disabled on v6 with a clearer reason (Linux PSA link ordering in IDF, not libsrtp).Reviewed by Cursor Bugbot for commit 232c60d. Bugbot is set up for automated code reviews on this repo. Configure here.