fix(mdns): Create static task only when SPIRAM-task-alloc is ON - #1110
fix(mdns): Create static task only when SPIRAM-task-alloc is ON#1110david-cermak wants to merge 2 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 030b9c5. Configure here.
030b9c5 to
063b1d9
Compare
| * only one browse is synchronized for that packet. This should not affect | ||
| * typical browse traffic, where packets answer one service type. | ||
| * | ||
| * @note Requires CONFIG_MDNS_ENABLE_BROWSE=y. |
There was a problem hiding this comment.
As this is enabled by default, I would phrase it as Can be disabled by ...
| set(MDNS_MEMORY "mdns_mem_caps.c") | ||
|
|
||
| set(MDNS_CORE "mdns_responder.c" "mdns_receive.c" "mdns_utils.c" "mdns_debug.c" "mdns_browser.c" "mdns_send.c" "mdns_netif.c" | ||
| if(CONFIG_MDNS_ENABLE_BROWSE) |
There was a problem hiding this comment.
nit: Append after is cleaner
|
Hi @david-cermak I think there is a function |
3 participants
Partially addresses #1100
Note
Medium Risk
Touches core mDNS task lifecycle and compile-time removal of browse paths; misconfiguration could break apps that call browse APIs with browse disabled.
Overview
Adds
CONFIG_MDNS_ENABLE_BROWSE(default on) so continuous browse (mdns_browse_new/ related RX, netif, console, andmdns_browser.c) can be stripped for ~3–4 KB flash when only advertise or one-shot queries are needed. Public browse APIs and browse CLI commands are wrapped in the same guard; CI buildssdkconfig.build_only.no_browsevia newsdkconfig.build_only.*steps in the mdns workflow.Separately, the mDNS service task now uses
xTaskCreatePinnedToCorewhen the stack stays on internal RAM andCONFIG_FREERTOS_TASK_CREATE_ALLOW_EXT_MEMis off;xTaskCreateStaticPinnedToCorewith caps-allocated stack is kept for SPIRAM task creation or when external task memory is allowed. Stack free on deinit follows that split.Reviewed by Cursor Bugbot for commit 05e7e4f. Bugbot is set up for automated code reviews on this repo. Configure here.