[mdns]: Minor fixes + Mutation tests/fault injection - #1109
Open
david-cermak wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches network announcement/probe/bye paths in production mDNS code; changes are defensive bounds fixes with low behavioral impact if the list is stable, but errors here could affect service discovery on device.
Overview
Hardens mDNS responder/PCB paths that walk the linked service list, fill a VLA, and pass a length into probe/bye helpers. Fill loops now cap with
i < srv_count(orl < srv_count) and downstream calls use the actual fill count (i/l) instead of the pre-countedsrv_count, reducing risk of out-of-bounds writes if count and list diverge.restart_pcb()gets the same pattern plus a comment typo fix (probe only IP).Host unit-test docs and tooling add
test_pcbto the CMake suite list, explain ASan vs clang-tidy ArrayBound vs Mull, and wire optional Mull mutation testing viamull.yml,USING_MULL.md, andscripts/run_mull.sh(clang plugin build + SQLite reports).Reviewed by Cursor Bugbot for commit 3250205. Bugbot is set up for automated code reviews on this repo. Configure here.