Skip to content

[mdns]: Minor fixes + Mutation tests/fault injection - #1109

Open
david-cermak wants to merge 2 commits into
espressif:masterfrom
david-cermak:fix/mdns_oob_pcb
Open

[mdns]: Minor fixes + Mutation tests/fault injection#1109
david-cermak wants to merge 2 commits into
espressif:masterfrom
david-cermak:fix/mdns_oob_pcb

Conversation

@david-cermak

@david-cermak david-cermak commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator
  • Fixes some obvious OOB access in MDNS
  • Adds experimental Mull engine to evaluate host/test suite

Note

Medium Risk
Touches network announcement/probe/bye paths in production mDNS code; changes are defensive bounds fixes with low behavioral impact if the list is stable, but errors here could affect service discovery on device.

Overview
Hardens mDNS responder/PCB paths that walk the linked service list, fill a VLA, and pass a length into probe/bye helpers. Fill loops now cap with i < srv_count (or l < srv_count) and downstream calls use the actual fill count (i / l) instead of the pre-counted srv_count, reducing risk of out-of-bounds writes if count and list diverge. restart_pcb() gets the same pattern plus a comment typo fix (probe only IP).

Host unit-test docs and tooling add test_pcb to the CMake suite list, explain ASan vs clang-tidy ArrayBound vs Mull, and wire optional Mull mutation testing via mull.yml, USING_MULL.md, and scripts/run_mull.sh (clang plugin build + SQLite reports).

Reviewed by Cursor Bugbot for commit 3250205. Bugbot is set up for automated code reviews on this repo. Configure here.

@david-cermak david-cermak self-assigned this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant