Skip to content

Correct archive filename (fix #9) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Correct archive filename (fix #9) #10

wants to merge 1 commit into from

Conversation

@jcassette
Copy link

@jcassette jcassette commented Jun 3, 2022 •
edited
Loading

Fix #9

@vikramdattu
Copy link
Contributor

vikramdattu commented Jun 6, 2022

@jcassette thanks for spotting and fixing this. We will review it internally and take the change.

@vikramdattu
Copy link
Contributor

vikramdattu commented Jun 6, 2022

Hi @jcassette, if you set PROJECT_VER in your top level CMakeList.txt, that is picked up and you won't fall to git describe path which you are.
We recommend you setting PROJECT_VER in project CMakeList.txt.

Example:

esp-insights/examples/minimal_diagnostics/CMakeLists.txt

Line 14 in 1d6bb17

set(PROJECT_VER "1.0")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Archive filename is incorrect

2 participants

@jcassette @vikramdattu