Skip to content

Reverts Backtrace: format to what it used to be (IDFGH-7580) - #9138

Merged
espressif-bot merged 1 commit into
espressif:masterfrom
MitchBradley:FixBacktrace
Jul 11, 2022
Merged

espressif-bot merged 1 commit into
espressif:masterfrom
MitchBradley:FixBacktrace

Conversation

@MitchBradley

Copy link
Copy Markdown
Contributor

Was: Backtrace: N:M N:M N:M ...
Now: Backtrace:N:MN:M N:M ...

The problem with the new format is that it is hard to parse and
breaks the parser that is used by PlatformIO. The old format
is much more reasonable. I do not see how the pattern in IDFDUT.py
can work with the new format, due to the missing space after the :

Possible fix for #8722

Was:  Backtrace: N:M N:M N:M ...
Now:  Backtrace:N:MN:M N:M ...

The problem with the new format is that it is hard to parse and
breaks the parser that is used by PlatformIO.  The old format
is much more reasonable.  I do not see how the pattern in IDFDUT.py
can work with the new format, due to the missing space after the :
@CLAassistant

CLAassistant commented Jun 11, 2022 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 11, 2022
@github-actions github-actions Bot changed the title Reverts Backtrace: format to what it used to be Reverts Backtrace: format to what it used to be (IDFGH-7580) Jun 11, 2022
MitchBradley added a commit to MitchBradley/platform-espressif32 that referenced this pull request Jun 11, 2022
Recent versions of ESP-IDF have a bug in which the Backtrace: line is
malformed.

Old/Good: Backtrace: 0xN:0xM 0xN:0xM 0xN:0xM ...
New/Bad:  Backtrace:0xN:0xM0xN:0xM 0xN:0xM ...

I issued espressif/esp-idf#9138 against
ESP-IDF to fix the underlying problem, but it is unclear when or if
that PR will be accepted, especially since the monitor program in
ESP-IDF is immune to the problem.

By using a decoding technique similar to the one in ESP-IDF's monitor,
either backtrace format can be accepted.

Supersedes platformio#687 , which does not quite work, in that it misses one of
the entries.
MitchBradley added a commit to bdring/FluidNC that referenced this pull request Jun 12, 2022
platformio.ini was inadvertently asking for the esp32 exception
decoder filter to be loaded twice into the pio monitor program,
causing problems with exception decoding.  This patch makes it
load only once, which helps with, but does not by itself solve,
exception decoding problems.  For the other necessary fixes,
see espressif/esp-idf#9138
and platformio/platform-espressif32#831

The first one is the correct fix to the root problem, while
the second one is a pragmatic short-term workaround.
@Alvin1Zhang

Copy link
Copy Markdown
Collaborator

Thanks for your contribution.

MitchBradley added a commit to bdring/FluidNC that referenced this pull request Jun 13, 2022
platformio.ini was inadvertently asking for the esp32 exception
decoder filter to be loaded twice into the pio monitor program,
causing problems with exception decoding.  This patch makes it
load only once, which helps with, but does not by itself solve,
exception decoding problems.  For the other necessary fixes,
see espressif/esp-idf#9138
and platformio/platform-espressif32#831

The first one is the correct fix to the root problem, while
the second one is a pragmatic short-term workaround.
ivankravets pushed a commit to platformio/platform-espressif32 that referenced this pull request Jun 16, 2022
Recent versions of ESP-IDF have a bug in which the Backtrace: line is
malformed.

Old/Good: Backtrace: 0xN:0xM 0xN:0xM 0xN:0xM ...
New/Bad:  Backtrace:0xN:0xM0xN:0xM 0xN:0xM ...

I issued espressif/esp-idf#9138 against
ESP-IDF to fix the underlying problem, but it is unclear when or if
that PR will be accepted, especially since the monitor program in
ESP-IDF is immune to the problem.

By using a decoding technique similar to the one in ESP-IDF's monitor,
either backtrace format can be accepted.

Supersedes #687 , which does not quite work, in that it misses one of
the entries.
@SoucheSouche

Copy link
Copy Markdown
Collaborator

Hello @MitchBradley,
The backtrace parsing issue you mentioned is going to be fixed using the proposed changes.
I will keep you informed of the state of the PR.

@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Resolution: NA Issue resolution is unavailable labels Jul 7, 2022
@SoucheSouche

Copy link
Copy Markdown
Collaborator

Hello @MitchBradley,
The changes were merged internally and will be available on GitHub in the next commit on the master branch.
This could take from a couple of days to a couple of weeks.
Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Resolution: Done Issue is done internally Status: Done Issue is done internally

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants