Skip to content

fix(esp_hal/adc_ll): missing-field-initializers (IDFGH-17806)#18716

Open
safocl wants to merge 1 commit into
espressif:masterfrom
safocl:fix-missing-field-initializers
Open

fix(esp_hal/adc_ll): missing-field-initializers (IDFGH-17806)#18716
safocl wants to merge 1 commit into
espressif:masterfrom
safocl:fix-missing-field-initializers

Conversation

@safocl

@safocl safocl commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

The first member of the union is a structure with multiple data elements, but only the first member is initialized using the {0} initializer.
However, this is not required since only uint8_t is used here.

This gave the error "missing-field-initializers".

 esp-idf/components/esp_hal_ana_conv/esp32/include/hal/adc_ll.h:253:45: error: missing initializer for member 'adc_ll_digi_pattern_table_t::<unnamed union>::<unnamed struct>::bit_width' [-Werror=missing-field-initializers]
   253 |     adc_ll_digi_pattern_table_t pattern = {0};
       |                                             ^
 

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

The first member of the union is a structure with multiple data
elements, but only the first member is initialized using the `{0}`
initializer.
However, this is not required since only `uint8_t` is used here.
@safocl safocl changed the title fix(esp_hal:adc_ll): missing-field-initializers fix(esp_hal/adc_ll): missing-field-initializers Jun 12, 2026
@github-actions github-actions Bot changed the title fix(esp_hal/adc_ll): missing-field-initializers fix(esp_hal/adc_ll): missing-field-initializers (IDFGH-17806) Jun 12, 2026
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 12, 2026
@espressif-bot espressif-bot assigned wanckl and Bruce297 and unassigned wanckl Jun 15, 2026
@songruo songruo added the PR-Sync-Merge Pull request sync as merge commit label Jun 15, 2026
@songruo

songruo commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

sha=09d14e36db26bb29f68cc227e1f53a589877f7dd

@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Sync-Merge Pull request sync as merge commit Status: In Progress Work is in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants