-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable Werror=unused-values (IDFGH-14511) #15277
base: master
Are you sure you want to change the base?
Conversation
It should warn, but not error out.
👋 Hello KaeLL, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
@KaeLL perhaps you could add, why do you think that the default behavior should be changed? If you want to allow this warning in your project, you can already do so, it doesn't seem to be necessary to change the default. |
I believe having dead code or unused variables is reason for warnings, which is what this change is all about, but not build-breaking errors. For regular development, it breaks the usual "edit-compile-test-debug" cycle in exchange for absolutely nothing of positive that a warning wouldn't suffice. For production builds, the code will likely end up eliminated by the compiler anyways. |
It should warn, but not error out.