-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exec permission to entrypoint.sh
script in Dockerfile. (IDFGH-12668)
#13660
Conversation
👋 Hello xiahualiu, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
entrypoint.sh
script in Dockerfile.entrypoint.sh
script in Dockerfile. (IDFGH-12668)
Changed the commit message and rebased the branch to pass the DangerJS pull request review check. |
I'm okay with this change. WDYT @antmak ? |
@xiahualiu Thank you for your contribution. Can you please install the pre-commit hooks (https://docs.espressif.com/projects/esp-idf/en/latest/esp32/contribute/install-pre-commit-hook.html) and make the commit while it is installed? It will point you to fix other issues as well. |
Seems like I need to change the from branch name to pass the pre-commit checks. I will close this PR and create a new one with pre-commit shortly. Sorry for the trouble, this is my first PR to esp-idf and thanks you for the reviews. |
Merged by 248d25a |
Hello Espressif team! This is a minor change to the Dockerfile in the tools folder.
The Dockerfile did not set exec permission for the
entrypoint.sh
script.I know the exec bit for
entrypoint.sh
is set in this git repository. But when user uses self-providedentrypoint.sh
without exec permission, it will break the Dock container. "unable to start container process: exec: "/opt/esp/entrypoint.sh": permission denied: unknown"Better do
chmod u+x /opt/esp/entrypoint.sh
afterCOPY
to make sureentrypoint.sh
is always executable.Also, it is better than
COPY --chmod=0755
, for older docker versions don't support the--chmod
option afterCOPY
.