Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exec permission to entrypoint.sh script in Dockerfile. (IDFGH-12668) #13660

Closed
wants to merge 1 commit into from
Closed

Conversation

xiahualiu
Copy link
Contributor

Hello Espressif team! This is a minor change to the Dockerfile in the tools folder.

The Dockerfile did not set exec permission for the entrypoint.sh script.

I know the exec bit for entrypoint.sh is set in this git repository. But when user uses self-provided entrypoint.sh without exec permission, it will break the Dock container. "unable to start container process: exec: "/opt/esp/entrypoint.sh": permission denied: unknown"

Better do chmod u+x /opt/esp/entrypoint.sh after COPY to make sure entrypoint.sh is always executable.

Also, it is better than COPY --chmod=0755, for older docker versions don't support the --chmod option after COPY.

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Apr 21, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello xiahualiu, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 8a3572f

@espressif-bot espressif-bot added the Status: Opened Issue is new label Apr 21, 2024
@github-actions github-actions bot changed the title Add exec permission to entrypoint.sh script in Dockerfile. Add exec permission to entrypoint.sh script in Dockerfile. (IDFGH-12668) Apr 21, 2024
@xiahualiu
Copy link
Contributor Author

Changed the commit message and rebased the branch to pass the DangerJS pull request review check.

@tomassebestik
Copy link
Member

I'm okay with this change. WDYT @antmak ?

@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed and removed Status: Opened Issue is new labels Apr 22, 2024
@dobairoland
Copy link
Collaborator

@xiahualiu Thank you for your contribution.

Can you please install the pre-commit hooks (https://docs.espressif.com/projects/esp-idf/en/latest/esp32/contribute/install-pre-commit-hook.html) and make the commit while it is installed? It will point you to fix other issues as well.

@xiahualiu
Copy link
Contributor Author

Seems like I need to change the from branch name to pass the pre-commit checks. I will close this PR and create a new one with pre-commit shortly. Sorry for the trouble, this is my first PR to esp-idf and thanks you for the reviews.

@xiahualiu xiahualiu closed this Apr 22, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Won't Do This will not be worked on and removed Status: Reviewing Issue is being reviewed labels Apr 23, 2024
@dobairoland
Copy link
Collaborator

Merged by 248d25a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Won't Do This will not be worked on Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants