Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct clang flag for size optimization (IDFGH-11295) #12449

Closed
wants to merge 1 commit into from

Conversation

storoj
Copy link
Contributor

@storoj storoj commented Oct 23, 2023

See https://clang.llvm.org/docs/CommandGuide/clang.html:

Code Generation Options
   -Oz Like -Os (and thus -O2), but reduces code size further.

Without -Oz enabled clang produced binaries that were too large.

See https://clang.llvm.org/docs/CommandGuide/clang.html:
>> Code Generation Options
>>   -Oz Like -Os (and thus -O2), but reduces code size further.

Without -Oz enabled clang produced binaries that were too large.
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Messages
📖 Good Job! All checks are passing!

👋 Welcome storoj, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

Generated by 🚫 dangerJS against 4acefd9

@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 23, 2023
@github-actions github-actions bot changed the title Use correct clang flag for size optimization Use correct clang flag for size optimization (IDFGH-11295) Oct 23, 2023
@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development and removed Status: Opened Issue is new labels Oct 25, 2023
@espressif-bot espressif-bot assigned ESP-Marius and unassigned 0xjakob Aug 15, 2024
@ESP-Marius
Copy link
Collaborator

After looking into this, changing to -Oz does indeed seem reasonable. We;ll discuss it further internally.

Thanks for your contribution!

@ESP-Marius
Copy link
Collaborator

sha=4acefd9df00aff1d926937840d327c890df1803a

@ESP-Marius ESP-Marius added the PR-Sync-Merge Pull request sync as merge commit label Aug 26, 2024
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Selected for Development Issue is selected for development Status: Reviewing Issue is being reviewed labels Aug 26, 2024
@SoucheSouche
Copy link
Collaborator

8fcc57b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants