fix(usb): fix warnings found by GNU static analyzer

espressif · Jun 18, 2024 · e1b9985 · e1b9985
1 parent 75277a9
commit e1b9985
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/components/usb/hcd_dwc.c b/components/usb/hcd_dwc.c
@@ -1593,9 +1593,12 @@ static dma_buffer_block_t *buffer_block_alloc(usb_transfer_type_t type)
         break;
     }
     dma_buffer_block_t *buffer = calloc(1, sizeof(dma_buffer_block_t));
+    if (buffer == NULL) {
+        return NULL;
+    }
     size_t real_len = 0;
     void *xfer_desc_list = transfer_descriptor_list_alloc(desc_list_len, &real_len);
-    if (buffer == NULL || xfer_desc_list == NULL) {
+    if (xfer_desc_list == NULL) {
         free(buffer);
         heap_caps_free(xfer_desc_list);
         return NULL;

diff --git a/components/usb/usb_phy.c b/components/usb/usb_phy.c
@@ -340,8 +340,10 @@ esp_err_t usb_new_phy(const usb_phy_config_t *config, usb_phy_handle_t *handle_r
     return ESP_OK;
 
 cleanup:
-    free(phy_context->iopins);
-    free(phy_context);
+    if (phy_context) {
+        free(phy_context->iopins);
+        free(phy_context);
+    }
     if (p_phy_ctrl_obj->ref_count == 0) {
         free(p_phy_ctrl_obj);
         p_phy_ctrl_obj = NULL;