fix: apps empty list is not None

espressif · Jul 19, 2024 · 5c23314 · 5c23314
1 parent 7042068
commit 5c23314
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/.gitlab/ci/host-test.yml b/.gitlab/ci/host-test.yml
@@ -314,8 +314,8 @@ test_pytest_qemu:
       --pytest-apps
       -m qemu
       --collect-app-info "list_job_${CI_JOB_NAME_SLUG}.txt"
-#      --modified-components ${MR_MODIFIED_COMPONENTS} will be fixed with IDFCI-2270
-#      --modified-files ${MR_MODIFIED_FILES}
+      --modified-components ${MR_MODIFIED_COMPONENTS}
+      --modified-files ${MR_MODIFIED_FILES}
     - python tools/ci/get_known_failure_cases_file.py
     - run_cmd pytest
       --target $IDF_TARGET
@@ -344,8 +344,8 @@ test_pytest_linux:
       --pytest-apps
       -m host_test
       --collect-app-info "list_job_${CI_JOB_NAME_SLUG}.txt"
-#      --modified-components ${MR_MODIFIED_COMPONENTS} will be fixed with IDFCI-2270
-#      --modified-files ${MR_MODIFIED_FILES}
+      --modified-components ${MR_MODIFIED_COMPONENTS}
+      --modified-files ${MR_MODIFIED_FILES}
     - python tools/ci/get_known_failure_cases_file.py
     - run_cmd pytest
       --target linux
@@ -376,8 +376,8 @@ test_pytest_macos:
       --pytest-apps
       -m \"host_test and macos_shell\"
       --collect-app-info "list_job_${CI_JOB_NAME_SLUG}.txt"
-#      --modified-components ${MR_MODIFIED_COMPONENTS} will be fixed with IDFCI-2270
-#      --modified-files ${MR_MODIFIED_FILES}
+      --modified-components ${MR_MODIFIED_COMPONENTS}
+      --modified-files ${MR_MODIFIED_FILES}
     - python tools/ci/get_known_failure_cases_file.py
     - run_cmd pytest
       --target linux

diff --git a/tools/ci/idf_pytest/plugin.py b/tools/ci/idf_pytest/plugin.py
@@ -82,7 +82,7 @@ def __init__(
 
         self.apps_list = (
             [os.path.join(idf_relpath(app.app_dir), app.build_dir) for app in apps if app.build_status == BuildStatus.SUCCESS]
-            if apps
+            if apps is not None
             else None
         )