Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrover): Add noglib configuration for Wrover Kit #370

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

tore-espressif
Copy link
Collaborator

@tore-espressif tore-espressif commented Aug 13, 2024

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

Create noglib version of Wrover-Kit. Will be used in noglib example

Example here #372

@tore-espressif tore-espressif self-assigned this Aug 13, 2024
@espzav
Copy link
Collaborator

espzav commented Aug 14, 2024

@tore-espressif Why did you selected Wrover Kit for noglib example? I think, better can be something newer like P4 EV board or S3 EV board. :-)
But for CI will be used all supported board in example, right?

@tore-espressif tore-espressif marked this pull request as ready for review August 15, 2024 08:21
@tore-espressif tore-espressif requested a review from espzav August 15, 2024 08:21
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tore-espressif tore-espressif merged commit c4b52aa into master Aug 16, 2024
18 checks passed
@tore-espressif tore-espressif deleted the faet/wrover_noglib branch August 16, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants