Skip to content

Renamed portTICK_RATE_MS to portTICK_PERIOD_MS in 2 files #8411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Renamed portTICK_RATE_MS to portTICK_PERIOD_MS in 2 files #8411

wants to merge 1 commit into from

Conversation

PilnyTomas
Copy link
Contributor

When compiling as an IDF component this resulted in compilation errors:

cores/esp32/esp32-hal-i2c.c:210:74: error: 'portTICK_RATE_MS' undeclared (first use in this function); did you mean 'portTICK_PERIOD_MS'?
  210 |     ret = i2c_master_cmd_begin((i2c_port_t)i2c_num, cmd, timeOutMillis / portTICK_RATE_MS);
      |                                                                          ^~~~~~~~~~~~~~~~
      |                                                                          portTICK_PERIOD_MS

@me-no-dev me-no-dev added this to the 3.0.0 milestone Jul 17, 2023
@PilnyTomas
Copy link
Contributor Author

Closing as more complete PR is opened: #8418

@PilnyTomas PilnyTomas closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@PilnyTomas @me-no-dev