Skip to content

Fixes RMT filter & idle timing and setup #8359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 20, 2023
Merged

Fixes RMT filter & idle timing and setup #8359

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
45480da
Fixes Filter and Idle parameter to uint32
SuGlider Jun 27, 2023
fa29291
Fixes Filter and Idle setup
SuGlider Jun 27, 2023
9adc276
Fixes it to 5.1Libs branch
SuGlider Jun 27, 2023
e20c0bf
fix RMT CLK source and Filter API
SuGlider Jul 18, 2023
ee38147
Merge branch 'esp-idf-v5.1-libs' into RMT_filter_idle_fix
SuGlider Jul 18, 2023
56ceb41
fixes missing ;
SuGlider Jul 18, 2023
9693908
fixes missing ;
SuGlider Jul 18, 2023
28bb0b8
fixes RMT example
SuGlider Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes it to 5.1Libs branch
  • Loading branch information
@SuGlider
SuGlider authored Jun 27, 2023
commit 9adc276b0f8dad376d6c419d5d4bed69de61f491
8 changes: 0 additions & 8 deletions cores/esp32/esp32-hal-rmt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,11 +494,7 @@ bool rmtInit(int pin, rmt_ch_dir_t channel_direction, rmt_reserve_memsize_t mem_
// TX Channel
rmt_tx_channel_config_t tx_cfg;
tx_cfg.gpio_num = pin;
#if CONFIG_IDF_TARGET_ESP32C6
tx_cfg.clk_src = RMT_CLK_SRC_DEFAULT;
#else
tx_cfg.clk_src = RMT_CLK_SRC_APB;
#endif
tx_cfg.resolution_hz = frequency_Hz;
tx_cfg.mem_block_symbols = SOC_RMT_MEM_WORDS_PER_CHANNEL * mem_size;
tx_cfg.trans_queue_depth = 10; // maximum allowed
Expand All @@ -523,11 +519,7 @@ bool rmtInit(int pin, rmt_ch_dir_t channel_direction, rmt_reserve_memsize_t mem_
// RX Channel
rmt_rx_channel_config_t rx_cfg;
rx_cfg.gpio_num = pin;
#if CONFIG_IDF_TARGET_ESP32C6
rx_cfg.clk_src = RMT_CLK_SRC_DEFAULT;
#else
rx_cfg.clk_src = RMT_CLK_SRC_APB;
#endif
rx_cfg.resolution_hz = frequency_Hz;
rx_cfg.mem_block_symbols = SOC_RMT_MEM_WORDS_PER_CHANNEL * mem_size;
rx_cfg.flags.invert_in = 0;
Expand Down