Skip to content

Removes -Werror=all from cflags #7060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Removes -Werror=all from cflags #7060

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ee8839d
Removes -Werror=all from cflags
SuGlider Jul 29, 2022
9e51e99
Merge branch 'master' into cflags--WError
SuGlider Jul 29, 2022
57db582
Merge branch 'espressif:master' into cflags--WError
SuGlider Aug 4, 2022
8df4963
uses platform.local.txt instead
SuGlider Aug 4, 2022
1688753
CI testing
SuGlider Aug 5, 2022
22cb8c7
CI testing - now should pass all CI testing cases
SuGlider Aug 5, 2022
4fbc7f7
adds platform.local.txt only to CI, by using script
SuGlider Aug 5, 2022
7de323a
fixes typos
SuGlider Aug 5, 2022
1cabb07
fixes CI script to copy platform.local.txt
SuGlider Aug 5, 2022
1b5c4d9
fixes CI PIO script to copy platform.local.txt
SuGlider Aug 5, 2022
bda1bc1
Adds platform.local.txt to cache monitoring
SuGlider Aug 5, 2022
0623d38
Added -Wno-error=format-overflow
SuGlider Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adds platform.local.txt only to CI, by using script
  • Loading branch information
@SuGlider
SuGlider committed Aug 5, 2022
commit 4fbc7f74a08294a1a3f48712cdf455962e80bbb0
2 changes: 2 additions & 0 deletions .github/scripts/install-arduino-core-esp32.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ if [ ! -d "$ARDUINO_ESP32_PATH" ]; then
else
echo "Cloning Core Repository..."
git clone https://github.com/espressif/arduino-esp32.git esp32 > /dev/null 2>&1
echo "Copying CI restrictive warning settings from tools/platform.local.txt"
cp tools/platform.local.txt .
fi

#echo "Updating Submodules ..."
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ jobs:
./tools/dist
~/arduino_ide
key: ${{ runner.os }}-${{ hashFiles('package/package_esp32_index.template.json',
'platform.txt',
'tools/get.py',
'.github/scripts/install-arduino-ide.sh') }}
- name: Build Sketches
Expand Down
39 changes: 0 additions & 39 deletions platform.local.txt
View file
Open in desktop

This file was deleted.

47 changes: 47 additions & 0 deletions tools/platform.local.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# Arduino Compile Warning Levels for the CI -- adding -Werror=all
compiler.warning_flags.more=-Wall -Werror=all
compiler.warning_flags.all=-Wall -Werror=all -Wextra

# Arduino Compiler Warning for CI -- forcing more strict Check
# ANY WARNING will result in Compilation ERROR

#
# Common Warning ignoring flags
#
#compiler.all.w_flags=-Wno-error=unused-function -Wno-error=unused-variable -Wno-error=deprecated-declarations -Wno-unused-parameter -Wno-sign-compare -Wno-error=unused-but-set-variable
compiler.all.w_flags=

#
# ESP32 Support Start
#
#compiler.c.w_flags.esp32={compiler.all.w_flags} -Wno-frame-address -Wno-old-style-declaration
#compiler.cpp.w_flags.esp32={compiler.all.w_flags} -Wno-frame-address
compiler.c.w_flags.esp32={compiler.all.w_flags}
compiler.cpp.w_flags.esp32={compiler.all.w_flags}
compiler.S.w_flags.esp32={compiler.all.w_flags}

#
# ESP32S3 Support Start
#
#compiler.c.w_flags.esp32s3={compiler.all.w_flags} -Wno-old-style-declaration
compiler.c.w_flags.esp32s3={compiler.all.w_flags}
compiler.cpp.w_flags.esp32s3={compiler.all.w_flags}
compiler.S.w_flags.esp32s3={compiler.all.w_flags}

#
# ESP32S2 Support Start
#
#compiler.c.w_flags.esp32s2={compiler.all.w_flags} -Wno-old-style-declaration
compiler.c.w_flags.esp32s2={compiler.all.w_flags}
compiler.cpp.w_flags.esp32s2={compiler.all.w_flags}
compiler.S.w_flags.esp32s2={compiler.all.w_flags}

#
# ESP32C3 Support Start
#
#compiler.c.w_flags.esp32c3={compiler.all.w_flags} -Wno-format -Wno-error=format= -Wno-old-style-declaration
#compiler.cpp.w_flags.esp32c3={compiler.all.w_flags} -Wno-error=format= -Wno-format
#compiler.S.w_flags.esp32c3={compiler.all.w_flags} -Wno-error=format= -Wno-format
compiler.c.w_flags.esp32c3={compiler.all.w_flags}
compiler.cpp.w_flags.esp32c3={compiler.all.w_flags}
compiler.S.w_flags.esp32c3={compiler.all.w_flags}