Skip to content

HttpClient: Add cookie support (cookie jar) #6216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 5, 2022
Merged

HttpClient: Add cookie support (cookie jar) #6216

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
603f0de
Support concatenation of headers (as in https://github.com/esp8266/Ar…
mattsches1 Jan 24, 2022
899ad9a
Add support for receiving, storing and sending cookies (cookie jar)
mattsches1 Jan 29, 2022
8e3df76
Cookie support: Respect `secure` attribute when sending a request
mattsches1 Jan 31, 2022
e682273
Fix missing `_secure` flag
mattsches1 Jan 31, 2022
bd8ec7d
Comment out support concatenation of headers (not needed anymore when…
mattsches1 Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix missing _secure flag
  • Loading branch information
@mattsches1
mattsches1 committed Jan 31, 2022
commit e682273fc19f075525e7689f83bb278db7ce4652
2 changes: 2 additions & 0 deletions libraries/HTTPClient/src/HTTPClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ bool HTTPClient::begin(WiFiClient &client, String url) {
}

_port = (protocol == "https" ? 443 : 80);
_secure = (protocol == "https");
return beginInternal(url, protocol.c_str());
}

Expand Down Expand Up @@ -190,6 +191,7 @@ bool HTTPClient::begin(WiFiClient &client, String host, uint16_t port, String ur
_port = port;
_uri = uri;
_protocol = (https ? "https" : "http");
_secure = https;
return true;
}

Expand Down