Skip to content

FFat remount failure #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2019
Merged

FFat remount failure #3282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Better cleanup on mount failures, as the idf api now seems to assign … 
…handle and mountpoint before failing. Fixes #3265
  • Loading branch information
@lbernstone
lbernstone committed Sep 26, 2019
commit 6c9133aaab2a9eb6cdfae0b3e47b0f6749213087
2 changes: 2 additions & 0 deletions libraries/FFat/src/FFat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ bool F_Fat::begin(bool formatOnFail, const char * basePath, uint8_t maxOpenFiles
esp_err_t err = esp_vfs_fat_spiflash_mount(basePath, partitionLabel, &conf, &_wl_handle);
if(err){
log_e("Mounting FFat partition failed! Error: %d", err);
esp_vfs_fat_spiflash_unmount(basePath, _wl_handle);
_wl_handle = WL_INVALID_HANDLE;
return false;
}
_impl->mountpoint(basePath);
Expand Down