Skip to content

Add Added unimplemented getCharacteristicsByHandle function #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2019
Merged

Add Added unimplemented getCharacteristicsByHandle function #3277

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cac5e5
Add Added unimplemented getCharacteristicsByHandle function
tanakamasayuki Sep 26, 2019
7d1e850
Delete log output
tanakamasayuki Sep 30, 2019
5d53f7a
Merge branch 'master' into add-BLE_getCharacteristicsByHandle
me-no-dev Sep 30, 2019
b35184c
Merge branch 'master' into add-BLE_getCharacteristicsByHandle
me-no-dev Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Delete log output
  • Loading branch information
@tanakamasayuki
tanakamasayuki committed Sep 30, 2019
commit 7d1e85099ff21d3269e2ae82d7d0bd8dc79195b8
2 changes: 0 additions & 2 deletions libraries/BLE/src/BLERemoteService.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,14 +231,12 @@ std::map<std::string, BLERemoteCharacteristic*>* BLERemoteService::getCharacteri
* @return A map of all the characteristics of this service.
*/
std::map<uint16_t, BLERemoteCharacteristic*>* BLERemoteService::getCharacteristicsByHandle() {
log_v(">> getCharacteristicsByHandle() for service: %s", getUUID().toString().c_str());
// If is possible that we have not read the characteristics associated with the service so do that
// now. The request to retrieve the characteristics by calling "retrieveCharacteristics" is a blocking
// call and does not return until all the characteristics are available.
if (!m_haveCharacteristics) {
retrieveCharacteristics();
}
log_v("<< getCharacteristicsByHandle() for service: %s", getUUID().toString().c_str());
return &m_characteristicMapByHandle;
} // getCharacteristicsByHandle

Expand Down