Skip to content

Fix long Ticker period conversion: cast ms to uint64_t when calculating us #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Fix long Ticker period conversion: cast ms to uint64_t when calculating us #3175

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2786c64
Fix long Ticker period conversion
full-stack-ex Sep 4, 2019
0b823be
Simplify long Ticker period conversion fix by using 1000ULL
full-stack-ex Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libraries/Ticker/src/Ticker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ void Ticker::_attach_ms(uint32_t milliseconds, bool repeat, callback_with_arg_t
}
esp_timer_create(&_timerConfig, &_timer);
if (repeat) {
esp_timer_start_periodic(_timer, milliseconds * 1000);
esp_timer_start_periodic(_timer, ((uint64_t)milliseconds) * 1000);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "ULL" to the 1000 as well to also force cast there. This is also done in the millis() function as seen here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 1000ULL added. Prior change (the uint64_t cast) reverted as redundant. Tested: Ticker used to fire after 900+ seconds, now it hasn't fired for 1342s, and counting.

} else {
esp_timer_start_once(_timer, milliseconds * 1000);
esp_timer_start_once(_timer, ((uint64_t)milliseconds) * 1000);
}
}

Expand Down