Skip to content

fix(ledc): Allow setting AnalogWrite frequency and resolution before calling analogWrite #11756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2025
Merged

fix(ledc): Allow setting AnalogWrite frequency and resolution before calling analogWrite #11756

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd405d2
fix(ledc): Allow setting AnalogWrite freq and res before ledc init
P-R-O-C-H-Y Aug 22, 2025
6c24dee
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ci(pre-commit): Apply automatic fixes
  • Loading branch information
@pre-commit-ci-lite
pre-commit-ci-lite[bot] authored Aug 27, 2025
commit 6c24deeeae1e6b37e8949f2534c0531eceb2ab49
4 changes: 2 additions & 2 deletions cores/esp32/esp32-hal-ledc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,7 @@ void analogWrite(uint8_t pin, int value) {

void analogWriteFrequency(uint8_t pin, uint32_t freq) {
ledc_channel_handle_t *bus = (ledc_channel_handle_t *)perimanGetPinBus(pin, ESP32_BUS_TYPE_LEDC);
if (bus != NULL) { // if pin is attached to LEDC change frequency, otherwise update the global frequency
if (bus != NULL) { // if pin is attached to LEDC change frequency, otherwise update the global frequency
if (ledcChangeFrequency(pin, freq, analog_resolution) == 0) {
log_e("analogWrite frequency cant be set due to selected resolution! Try to adjust resolution first");
return;
Expand All @@ -796,7 +796,7 @@ void analogWriteFrequency(uint8_t pin, uint32_t freq) {

void analogWriteResolution(uint8_t pin, uint8_t resolution) {
ledc_channel_handle_t *bus = (ledc_channel_handle_t *)perimanGetPinBus(pin, ESP32_BUS_TYPE_LEDC);
if (bus != NULL) { // if pin is attached to LEDC change resolution, otherwise update the global resolution
if (bus != NULL) { // if pin is attached to LEDC change resolution, otherwise update the global resolution
if (ledcChangeFrequency(pin, analog_frequency, resolution) == 0) {
log_e("analogWrite resolution cant be set due to selected frequency! Try to adjust frequency first");
return;
Expand Down
Loading