Skip to content

feat(ledc): max resolution review #11226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
+38 −23
Draft

feat(ledc): max resolution review #11226

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
be00779
feat(ledc): max resolution review
SuGlider Apr 7, 2025
940cf59
feat(ledc): check duty limit based on the resolution
SuGlider Apr 7, 2025
443f7e1
fix(ledc): removing white space in code line
SuGlider Apr 7, 2025
591a161
fix(ledc): reverting not necessary change
SuGlider Apr 7, 2025
cdd04b1
feat(ledc): testing values that shall be consistent
SuGlider Apr 7, 2025
08fea23
fix(ledc): failing to execute shall issue error log
SuGlider May 3, 2025
174becc
fix(ledc): missing correct log message format
SuGlider May 3, 2025
21cdf94
Merge branch 'master' into ledc_max_resolution_review
SuGlider May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(ledc): removing white space in code line
  • Loading branch information
@SuGlider
SuGlider authored Apr 7, 2025
commit 443f7e10f1d5bc88af426314d9f805bceaff8992
1 change: 0 additions & 1 deletion cores/esp32/esp32-hal-ledc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ bool ledcWrite(uint8_t pin, uint32_t duty) {
log_w("Target duty %d was adjusted to the maximum duty %d", duty, max_duty);
duty = max_duty;
}

ledc_set_duty(group, channel, duty);
ledc_update_duty(group, channel);

Expand Down
Loading