Skip to content

feat(touch): Support NG touch driver for P4 #10448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2024
Merged

feat(touch): Support NG touch driver for P4 #10448

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
030c07e
feat(touch): Support NG touch driver for P4
P-R-O-C-H-Y Oct 10, 2024
ae7b57f
fix(ci): Touch test + IDF compilation fixes
P-R-O-C-H-Y Oct 11, 2024
9cb63e2
fix(ci): remove debug prints from touch test
P-R-O-C-H-Y Oct 11, 2024
da31968
fix(ci): Fix touch test for esp32
P-R-O-C-H-Y Oct 11, 2024
69f0968
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(ci): remove debug prints from touch test
  • Loading branch information
@P-R-O-C-H-Y
P-R-O-C-H-Y committed Oct 11, 2024
commit 9cb63e2346a23b0333b53729a5b2b9e3fba577ce
2 changes: 0 additions & 2 deletions tests/validation/touch/touch.ino
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test work properly on your board ? Mine is the older version and it fails 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mine P4-EV board v1.4 it worked.

Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ void test_touch_read(void) {
touch_value_t touch_unpressed[sizeof(TOUCH_GPIOS)];
for (int i = 0; i < sizeof(TOUCH_GPIOS); i++) {
touch_unpressed[i] = touchRead(TOUCH_GPIOS[i]);
Serial.printf("\nUNPRESSED for CH%d = %d", i, touch_unpressed[i]);
}

// TEST PRESS STATE
Expand All @@ -153,7 +152,6 @@ void test_touch_read(void) {
touch_value_t touch_pressed[sizeof(TOUCH_GPIOS)];
for (int k = 0; k < sizeof(TOUCH_GPIOS); k++) {
touch_pressed[k] = touchRead(TOUCH_GPIOS[k]);
Serial.printf("\nPRESSED for CH%d = %d", k, touch_pressed[k]);
}

// COMPARE PRESSED > UNPRESSED
Expand Down
Loading