Skip to content

FS library position() to return (size_t) -1 on error #10002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2024
Merged

FS library position() to return (size_t) -1 on error #10002

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e01bf1b
position_fix
drmpf Jul 10, 2024
5f586c4
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/FS/src/FS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ bool File::seek(uint32_t pos, SeekMode mode) {

size_t File::position() const {
if (!*this) {
return 0;
return (size_t)-1;
}

return _p->position();
Expand Down
2 changes: 1 addition & 1 deletion libraries/FS/src/FS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class File : public Stream {
bool seek(uint32_t pos) {
return seek(pos, SeekSet);
}
size_t position() const;
size_t position() const; // returns (size_t)-1 on error
size_t size() const;
bool setBufferSize(size_t size);
void close();
Expand Down