Optimize layers #42
Merged
Optimize layers #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collpase installation layers and image went from 550Mb to 370mb
9 tasks
whalelines
reviewed
Apr 19, 2024
| # Install required libs | ||
| RUN set -ex; \ | ||
| apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false; \ | ||
| # Install required libs |
whalelines
reviewed
Apr 19, 2024
Comment on lines
-6
to
+11
| # Install php libs | ||
| RUN set -ex; \ | ||
| \ | ||
| aptMarkList="$(apt-mark showmanual)"; \ | ||
| \ | ||
| apt-get update; \ | ||
| # Install php libs |
There was a problem hiding this comment.
The whole thing is about PHP, so may not move this?
|
@whalelines the answer to both questions is that the second install step relies on the cache not being cleared in the previous step. So either we duplicate the update and clear cache or we put them in the same layer. The latter is faster to build |
|
But if you are combining those two |
|
That purge gets rids of build dependencies for the PHP deps which is not the same as the cache. |
|
@LaurentGoderre thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collpase installation layers and image went from 550Mb to 370mb