Add GitHub Actions #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, I'm not sure why the Actions workflow doesn't work in this pull request .. |
|
@sw005320 Could you review this PR? |
sw005320
approved these changes
Feb 18, 2021
|
Thank you for the review. Let me merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided to use GitHub Actions instead of Travis CI because
When new release is published, the Actions workflow uploads wheels to the release page.
Originally in #35 (comment) , I was going to serve wheels in this repository, but I found that serving wheels as assets of a release page is much easier.
Users will be able to install a wheel like this,
$ pip install warpctc_pytorch==X.Y.Z+torchXX.cudaXX -f https://github.com/espnet/warp-ctc/releases/tag/vX.Y.ZAfter this pull request is merged, I'll publish a new release and see if the wheels are attached to the release page.