-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/sizes.py: Restore to the prior behavior regarding output destination #8572
Conversation
Should we, though? This is not an error, as the coloring might suggest, but a simple informative message. BTW I thought we had an option to replace Lines 157 to 161 in 1bb041b
It is actually something hard-coded Only future 2.0.0 IDE allows to have a custom output (by reading certain JSON field) |
Not really, based on the builder's code :/ I have tried recipe.hooks.sketch.postbuild.1.pattern="{runtime.tools.python3.path}/python3" -I "{runtime.tools.sizes}" --elf "{build.path}/{build.project_name}.elf" --path "{runtime.tools.xtensa-lx106-elf-gcc.path}/bin" --mmu "{build.mmuflags}" Oh well. |
…ation once `tools/sizes.py` outputted to `stderr` rather `stdout` before da4a19f (Arduino IDE 1.8.19 for Windows doesn't capture `stdout`, 2.0.0-rc6 does)
3c12311
to
d52e712
Compare
I happened to take a look at this today, and was confused by the quoted statement. Since the "why is it printed in red in the IDE" question is likely to be raised by the users periodically, I'll add some information here: When the "Show verbose output during: ☐ compilation" Arduino IDE preference is disabled, the IDE only prints the output from the stderr stream of the compilation commands. The stdout stream output of the commands is only printed when that preference is enabled. This handling of compilation output is the same in Arduino IDE 1.x and 2.x so I can only think of two possible causes of the claimed different behavior between the two versions:
|
once
tools/sizes.py
outputted tostderr
ratherstdout
before da4a19f(Arduino IDE 1.8.19 for Windows doesn't capture
stdout
, 2.0.0-rc6 does)