Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WString: remove operator==(const __FlashStringHelper*) #8569

Merged
merged 8 commits into from
May 17, 2022
Merged

WString: remove operator==(const __FlashStringHelper*) #8569

merged 8 commits into from
May 17, 2022

Commits on May 16, 2022

  1. WString: overload ==

    @d-a-v
    d-a-v committed May 16, 2022
    Configuration menu
    Copy the full SHA
    e15fc91 View commit details
    Browse the repository at this point in the history

  2. keep only nullptr comparison overload

    @d-a-v
    d-a-v committed May 16, 2022
    Configuration menu
    Copy the full SHA
    a5cc344 View commit details
    Browse the repository at this point in the history

  3. removing ==(FlashStringHelper) overload: 

    Comparison with `P("test")` will use an implicit temporary `String(P("test"))` and restore warning-less & correct comparison with NULL through `==(const char*)` overload.
    @d-a-v
    d-a-v committed May 16, 2022
    Configuration menu
    Copy the full SHA
    e4b47bc View commit details
    Browse the repository at this point in the history

  4. restore the ==flashstringhelper overload, add ==decltype(NULL)

    @d-a-v
    d-a-v committed May 16, 2022
    Configuration menu
    Copy the full SHA
    a02c21c View commit details
    Browse the repository at this point in the history

  5. deprecate usage of NULL

    @d-a-v
    d-a-v committed May 16, 2022
    Configuration menu
    Copy the full SHA
    bc52bd6 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Merge branch 'master' into streqeq

    @d-a-v
    d-a-v committed May 17, 2022
    Configuration menu
    Copy the full SHA
    b912a70 View commit details
    Browse the repository at this point in the history

  2. removing again ==(FlashStringHelper) overload

    @d-a-v
    d-a-v committed May 17, 2022
    Configuration menu
    Copy the full SHA
    65ad698 View commit details
    Browse the repository at this point in the history

  3. revert changes about operator bool()

    @d-a-v
    d-a-v committed May 17, 2022
    Configuration menu
    Copy the full SHA
    fb666ef View commit details
    Browse the repository at this point in the history