Skip to content

fixes for WiFiClient::write(Stream) #7987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 27, 2021
Merged

fixes for WiFiClient::write(Stream) #7987

merged 8 commits into from
Apr 27, 2021

Conversation

@d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Apr 15, 2021 •
edited
Loading

  • remove deprecated WiFiClient::write(Stream,size)
  • fix and deprecate WiFiClient::write(Stream) to use Stream::sendAll instead of ::sendAvailable
  • update ESP8266WebServer::streamFile to use file.sendAll(client) instead of client.write(file)

fixes #7982

edit:

  • remove Stream dependency in ClientContext::

fixes #7991

edit2: 212 flash bytes are saved when compiling mcve from #7991

@d-a-v
fixes for WiFiClient::write(Stream)
ae87978 
- remove deprecated WiFiClient::write(Stream,size)
- fix and deprecate WiFiClient::write(Stream) to use Stream::sendAll instead of ::sendAvailable
- update ESP8266WebServer::streamFile to use file.sendAll(client) instead of client.write(file)
@d-a-v d-a-v added this to the 3.0.0 milestone Apr 15, 2021
@d-a-v d-a-v mentioned this pull request Apr 17, 2021
Closed
6 tasks
@d-a-v d-a-v added the alpha included in alpha release label Apr 17, 2021
@d-a-v d-a-v mentioned this pull request Apr 21, 2021
Closed
6 tasks
devyte
devyte approved these changes Apr 25, 2021
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumps out at me, 👍

@d-a-v d-a-v merged commit f4178e5 into esp8266:master Apr 27, 2021
@d-a-v d-a-v deleted the streamsendfix3 branch April 27, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devyte devyte devyte approved these changes

Assignees

No one assigned

Labels

alpha included in alpha release

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

Panic inside ClientContext.h since git version 83f5f29c streamFile does only send first 64 bytes

2 participants

@d-a-v @devyte