Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hexdump fix&update #7831

Merged
merged 6 commits into from
Jan 22, 2021
Merged

Hexdump fix&update #7831

merged 6 commits into from
Jan 22, 2021

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jan 19, 2021

  • hexdump() must be declared as "C" like its C counterpart.
  • add ascii data in dump
  • avoid caps

@d-a-v d-a-v changed the title Hexdump Hexdump fix&update Jan 19, 2021
@d-a-v d-a-v merged commit b3fe0aa into esp8266:master Jan 22, 2021
@d-a-v d-a-v deleted the hexdump branch January 22, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-a-v @earlephilhower @devyte