-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ESP8266HTTPClient.cpp for no Content-Length #7691
Conversation
Response bodies are ignored when _transferEncoding == HTTPC_TE_IDENTITY and there is no Content-Length header. The added code here fixes that issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little minor refactor, please.
Sync with esp8266/Arduino master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup.
Now that it's working but with an unwilling timeout, you can update |
With apologies, I'm not seeing how this would help, at least in the current implementations of Perhaps the word 'meantime' threw me and you are asking for the |
In #6979, But before #6979 is considered, a fix is needed for your issue, and #7692 too which is the same issue. End of TCP connection cannot currently be handled by
If this works for you, please update your PR. |
Add logic to writeToStreamDataBlock to only read what's available so as to avoid timeout, and adjust formatting.
That worked nicely. And now I understand what you meant about effectively checking |
Response bodies are ignored when _transferEncoding == HTTPC_TE_IDENTITY and there is no Content-Length header. The added code here attempts to fix that issue by writing the response body based upon how much content is available to be read.
edit:
Fixes #7692