Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: gcc handles duplicate literal strings #7531

Merged
merged 7 commits into from
Aug 17, 2020
Merged

doc: gcc handles duplicate literal strings #7531

merged 7 commits into from
Aug 17, 2020

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Aug 16, 2020

No description provided.

@devyte devyte added this to the 3.0.0 milestone Aug 16, 2020
earlephilhower
earlephilhower approved these changes Aug 17, 2020
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just double checked and we're setting the "coalesce strings" flag in pgmspace.h, so all is well!

@earlephilhower earlephilhower merged commit f42327d into esp8266:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@devyte devyte devyte approved these changes

Assignees

@earlephilhower earlephilhower

Labels
component: documentation
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@d-a-v @earlephilhower @devyte