mDNS: protect MDNSResponder::queryService against misuse #7216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devyte
requested changes
Apr 15, 2020
| @@ -767,6 +767,10 @@ uint32_t MDNSResponder::queryService(const char* p_pcService, | |||
| const char* p_pcProtocol, | |||
| const uint16_t p_u16Timeout /*= MDNS_QUERYSERVICES_WAIT_TIME*/) | |||
| { | |||
| if (0 == m_pUDPContext) | |||
There was a problem hiding this comment.
Isn't this a ptr? check against nullptr?
There was a problem hiding this comment.
Yes. For coherency I sticked to this file's style.
Arduino/libraries/ESP8266mDNS/src/LEAmDNS.cpp
Line 101 in e1789dd
I was afraid to modify too much for when LEAmDNS2 is coming to avoid merge complication.
devyte
approved these changes
Apr 15, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7215