Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: urlDecode done before parsing args #2956

Merged
merged 2 commits into from
Aug 1, 2017
Merged

Conversation

DottoreTozzi
Copy link
Contributor

@DottoreTozzi DottoreTozzi commented Feb 13, 2017

Currently, urlDecode() is being called before parsing arguments by '&'.
This is causing problems when passing a string containing special characters, strong passwords for example (WPA2-PSK in my particular scenario).
This tiny patch fixed it for me, while otherwise I'd have to use enctype="multipart/form-data" as a workaround.
I hope this won't break anything else (I've tested it thoroughly, however).

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@af58a74). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2956   +/-   ##
=========================================
  Coverage          ?   27.82%           
=========================================
  Files             ?       20           
  Lines             ?     3626           
  Branches          ?      656           
=========================================
  Hits              ?     1009           
  Misses            ?     2441           
  Partials          ?      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af58a74...90de38d. Read the comment docs.

@universam1
Copy link

@igrr Any reason why this is not getting merged? Severe bug imho. Thanks!

@igrr
Copy link
Member

igrr commented Aug 1, 2017

Paging @me-no-dev to review this.

Ideally, a test case for this in https://github.com/esp8266/Arduino/blob/master/tests/device/test_http_server/test_http_server.ino would be nice to have, but I'm not going to ask @DottoreTozzi to figure out how the testing framework works :)

@DottoreTozzi
Copy link
Contributor Author

I actually might, once I'm back from holidays (mid August).

@me-no-dev
Copy link
Collaborator

I approve this merge :) had stumbled upon similar issue on the Async front recently ;)

@universam1
Copy link

thanks @me-no-dev @igrr !!

@igrr igrr merged commit f5b6e16 into esp8266:master Aug 1, 2017
@pieman64
Copy link

pieman64 commented Aug 1, 2017

@igrr will this commit also cover #3398 or are they separate issues?

@igrr
Copy link
Member

igrr commented Aug 1, 2017

@pieman64 Not sure. @me-no-dev and @teejaydub please check and advise!

@teejaydub
Copy link
Contributor

No, it's a similar area of the code, but two distinct issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants