-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: urlDecode done before parsing args #2956
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2956 +/- ##
=========================================
Coverage ? 27.82%
=========================================
Files ? 20
Lines ? 3626
Branches ? 656
=========================================
Hits ? 1009
Misses ? 2441
Partials ? 176 Continue to review full report at Codecov.
|
@igrr Any reason why this is not getting merged? Severe bug imho. Thanks! |
Paging @me-no-dev to review this. Ideally, a test case for this in https://github.com/esp8266/Arduino/blob/master/tests/device/test_http_server/test_http_server.ino would be nice to have, but I'm not going to ask @DottoreTozzi to figure out how the testing framework works :) |
I actually might, once I'm back from holidays (mid August). |
I approve this merge :) had stumbled upon similar issue on the Async front recently ;) |
thanks @me-no-dev @igrr !! |
@pieman64 Not sure. @me-no-dev and @teejaydub please check and advise! |
No, it's a similar area of the code, but two distinct issues. |
Currently, urlDecode() is being called before parsing arguments by '&'.
This is causing problems when passing a string containing special characters, strong passwords for example (WPA2-PSK in my particular scenario).
This tiny patch fixed it for me, while otherwise I'd have to use enctype="multipart/form-data" as a workaround.
I hope this won't break anything else (I've tested it thoroughly, however).