Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete core_version.h from 3.0.0 release .zip #8049

Closed
mcspr opened this issue May 18, 2021 · 1 comment
Closed

Incomplete core_version.h from 3.0.0 release .zip #8049

mcspr opened this issue May 18, 2021 · 1 comment
Assignees
@d-a-v
Labels
component: packaging type: bug
Milestone
3.0.1

Comments

@mcspr
Copy link
Collaborator

mcspr commented May 18, 2021

Current archive contains these:

#define ARDUINO_ESP8266_GIT_VER 0xefb0341a
#define ARDUINO_ESP8266_GIT_DESC 3.0.0
#define ARDUINO_ESP8266_RELEASE_
#define ARDUINO_ESP8266_RELEASE ""

which should probably have been ARDUINO_ESP8266_RELEASE_3_0_0 and ARDUINO_ESP8266_RELEASE "3_0_0"?
@d-a-v d-a-v self-assigned this May 18, 2021
@d-a-v d-a-v added this to the 3.0.1 milestone May 18, 2021
@JAndrassy JAndrassy mentioned this issue May 23, 2021
Closed
6 tasks
d-a-v added a commit to d-a-v/Arduino that referenced this issue May 23, 2021
@d-a-v
release script: protect bash variables and add logs
34a4c3a 
Ref: esp8266#8049
Ref: empty variable https://github.com/esp8266/Arduino/runs/2592755965?check_suite_focus=true#step:5:35
@d-a-v d-a-v mentioned this issue May 23, 2021
Merged
d-a-v added a commit that referenced this issue May 23, 2021
@d-a-v
release script: protect bash variables and add logs (#8074)
78a2ed6 
Ref: #8049
Ref: empty variable https://github.com/esp8266/Arduino/runs/2592755965?check_suite_focus=true#step:5:35
@d-a-v d-a-v mentioned this issue Jun 10, 2021
Closed
6 tasks
@agners agners mentioned this issue Jun 11, 2021
Merged
9 tasks
This was referenced Jun 11, 2021
Closed
Merged
@d-a-v
Copy link
Collaborator

d-a-v commented Jun 16, 2021

This has been fixed by #8126 and #8127

Next 3.0.1 release will have

#define ARDUINO_ESP8266_GIT_VER   0xA11900D
#define ARDUINO_ESP8266_GIT_DESC  3.0.1
#define ARDUINO_ESP8266_VERSION   3.0.1

#define ARDUINO_ESP8266_MAJOR     3
#define ARDUINO_ESP8266_MINOR     0
#define ARDUINO_ESP8266_REVISION  1

#define ARDUINO_ESP8266_RELEASE   "3.0.1"
#define ARDUINO_ESP8266_RELEASE_3_0_1

@d-a-v d-a-v closed this as completed Jun 16, 2021
@d-a-v d-a-v mentioned this issue Jun 24, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-a-v d-a-v

Labels
component: packaging type: bug
Projects
None yet
Milestone
3.0.1
Development

No branches or pull requests
2 participants
@mcspr @d-a-v