Error message "fatal: not a git repository" when using the GIT snapshot

[M-Reimer]

Basic Infos

• This issue complies with the issue POLICY doc.
• I have read the documentation at readthedocs and the issue is not addressed there.
• I have tested that the issue is present in current master branch (aka latest git).
• I have searched the issue tracker for a similar issue.
• If there is a stack dump, I have decoded it.
• I have filled out all fields below.

Platform

• Hardware: other AI-Thinker ESP8266MOD
• Core Version: 47e7b2d
• Development Env: Arduino IDE
• Operating System: Arch Linux

Settings in IDE

• Module: Wemos D1 mini r2
• Flash Mode: ?
• Flash Size: 4MB/1MB
• lwip Variant: v2 Lower Memory
• Reset Method: ?
• Flash Frequency: 40Mhz
• CPU Frequency: 80Mhz
• Upload Using: SERIAL
• Upload Speed: 921600

Problem Description

If I create a toolchain based on the GIT snapshot (ZIP file), then I always get the following message prior compiling:

fatal: not a git repository (or any of the parent directories): .git

Reason is that this script tries to fetch some info using GIT:

https://github.com/esp8266/Arduino/blob/master/tools/makecorever.py

The message does not cause any problems. It just looks ugly.

How do you plan to fix this? Hide the message? I could create a pull request if I know how you want this to be fixed.

[d-a-v]

Can you try with:

diff --git a/tools/makecorever.py b/tools/makecorever.py
index e7bd3486..659591b5 100755
--- a/tools/makecorever.py
+++ b/tools/makecorever.py
@@ -26,7 +26,7 @@ def generate(path, platform_path, git_ver="ffffffff", git_desc="unspecified"):
     def git(*args):
         cmd = ["git", "-C", platform_path]
         cmd.extend(args)
-        proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, universal_newlines=True)
+        proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, universal_newlines=True, stderr=DEVNULL)
         return proc.stdout.readlines()[0].strip()
 
     try:

If that suits your need, would you make a pull request ?

[M-Reimer]

Done: #7745

[d-a-v]

closed by #7745