-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebServer.serveStatic: index.html.gz as default doesn't work (while index.html does) #6984
Comments
2 and 3 should be reversed. |
I would humbly suggest that anyone evil enough to have both a |
Fixes esp8266#6984 When a directory index is requested with an explicit index.html, follow the original webserver order and check for: index.htm, index.htm.gz, index.html, index.html.gz, in order. Fixes the regressions introduced in 9f2cfb8 and 6768116
Thanks for picking this up during my radio silence. I was still planning to get back to this, but had since moved on to non-esp projects and didn't get around to this. Now there's just my other (accepted) pull request which is in need of a follow-up... |
Apologies for forgoing the prescribed format. I noticed this problem while reading the code and though I did test it, that does make things like hardware information irrelevant. I decided to cut out that noise instead. (The issue that this is related to also didn't follow that format...)
Using
index.html
instead ofindex.htm
for the "folder" is supported since 9f2cfb8At that time, the lookup order became:
As #6792 pointed out, this broke support for
index.htm.gz
and this was changed in 6768116 . The lookup order now is:However, this has removed support for using
index.html.gz
completely. I think the lookup order should include four items:(Perhaps with 2 & 3 reversed.)
The text was updated successfully, but these errors were encountered: