-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USB Host Shield Library fails to compile using 2.4.0 #4154
Comments
@gdsports it's right there send nd line down: |
Clean compile with this patch.
|
@gdsports I understand why you want that. However, use of #defined min/max is considered a potential bug in the C++ world. Even C compilers warn about some different type comparisons. |
FWIW, I think that there are a few cases in which std::min/max produce errors, but can actually be unambiguously resolved by widening the two types. E.g. if Ta is uint8 and Tb is int32, then a can be widened to int32 instead of producing an error. Of course, in some cases it is not possible — e.g. when int32 and uint64 are being compared. |
error - esp8266/Arduino#4154
error - esp8266/Arduino#4154
Basic Infos
USB Host Shield Library 2.0 compiles using 2.3.0 but fails to 2.4.0.
Hardware
Hardware: Any
Core Version: 2.4.0 and git master
Description
The USB Host Shield Library 2.0 example board_qc.ino compiles using 2.3.0 but fails using 2.4.0. Other examples fail to compile in the same way.
The problem started with the same commit as in #4096.
Settings in IDE
Module: NodeMCU 1.0
default values
Debug Messages
The text was updated successfully, but these errors were encountered: