Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Aug 28, 2023

  • Adds a __post_init hook, like we have in esp-riscv-rt
  • Updates dependencies to their latest versions
    • Updated syn from 1.x to 2.x in the proc-macro crate
  • Bumped version numbers of xtensa-lx-rt-proc-macros and xtensa-lx-rt packages in preparation for new release
  • Added a rust-toolchain.toml file

Sorry for the other noise, just trying to get the Cargo manifests consistent with the others. Additionally I bumped the MSRV to 1.65 since that's what we're using for the PACs/HALs anyway.

@bjoernQ
Copy link
Contributor

bjoernQ commented Aug 28, 2023

I think we don't use it anyway but in xtensa.in.x we probably want to add

PROVIDE(__post_init = default_post_init);

or maybe we want to get rid of xtensa.in.x completely ... not sure

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the thing about xtensa.in.x this looks good to me

@jessebraham
Copy link
Member Author

Okay I've updated the linker script for now, guess we can discuss whether or not to remove the linker script at another time.

Thanks for the review!

@jessebraham jessebraham merged commit b9e653d into esp-rs:master Aug 28, 2023
@jessebraham jessebraham deleted the fixes/updates branch August 28, 2023 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants