Skip to content

Add https example CI check and simplify sdkconfig.defaults #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 1, 2023
Merged

Add https example CI check and simplify sdkconfig.defaults #142

merged 5 commits into from
Mar 1, 2023

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Mar 1, 2023 •
edited
Loading

@SergioGasquez SergioGasquez linked an issue Mar 1, 2023 that may be closed by this pull request
Fix HTTPS client example #136
Closed
MabezDev
MabezDev reviewed Mar 1, 2023
View reviewed changes
MabezDev
MabezDev approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergioGasquez SergioGasquez merged commit f10dc6c into esp-rs:main Mar 1, 2023
@SergioGasquez SergioGasquez deleted the fix/https-example branch March 1, 2023 14:27
@SergioGasquez SergioGasquez mentioned this pull request Mar 1, 2023
Closed
@SergioGasquez SergioGasquez changed the title Add https example CI check Add https example CI check and simplify sdkconfig.defaults Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igrr igrr igrr left review comments

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix HTTPS client example
3 participants
@SergioGasquez @igrr @MabezDev