`f32::min` etc cause linker errors on bare-metal

[bjoernQ]

Seems like that intrinsic generates code that wants to call fminf which is not present on bare-metal

It works fine with RISCV targets

[MabezDev]

Do you remeber which target this was reproduced on?

Looks like for soft float targets we just need to enable it upstream, like it was done for riscv: rust-lang/compiler-builtins#493. If this was reproduced on an ESP32 or ESP32S3 then we're missing the intrinsics in LLVM.

[bjoernQ]

Ah I always wonder why people don't give hints on the used target and now I see I'm doing that, too.
But I remember it was on ESP32-S3 (at least some Xtensa target)

[MabezDev]

This should be fixed by rust-lang/compiler-builtins#517, whilst S3 and ESP32 have fp acceleration, they have no accelerations for fmin/fmax etc and therefore must fall back to soft float implementations.

[MabezDev]

With the 1.70 release, the compiler-builtins changes have been reflected! We can now close this.

To anyone running into duplicate symbol linker errors, you need to remove any of your own implementations in your crates/projects.