Change long form of save-image --ignore-app-descriptor - #974
Merged
Conversation
SergioGasquez
left a comment
Member
There was a problem hiding this comment.
The change looks good, and it's something we definitely want to do, but this would be considered a breaking change that requires a major bump. We could support both ignore_app_descriptor and ignore-app-descriptor or just wait and merge this when working towards v5.
SergioGasquez
requested changes
Dec 3, 2025
SergioGasquez
left a comment
Member
There was a problem hiding this comment.
Can you modify this PR to support both ignore_app_descriptor and ignore-app-descriptor while adding a TODO that the underscore version should be removed for v5??
Contributor
Author
|
I've used |
SergioGasquez
approved these changes
Dec 5, 2025
SergioGasquez
left a comment
Member
There was a problem hiding this comment.
LGTM! A visible_alias should be fine, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #973