Skip to content

Fix MMU page size handling #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 8, 2025
Merged

Fix MMU page size handling #835

merged 8 commits into from
Apr 8, 2025

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Apr 7, 2025 •
edited
Loading

This PR:

  • bubbles up the flash segment that contains the app descriptor to the first position
  • reads AppDescriptor and extracts the MMU page size
  • allows the user to specify an MMU page size
  • defines the valid page sizes per chip to double-check what we set/inferred
  • pads sections according to the MMU page size

Fixes #741

@bugadani bugadani marked this pull request as draft April 7, 2025 14:34
@bugadani bugadani marked this pull request as ready for review April 7, 2025 14:43
jessebraham
jessebraham approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@jessebraham jessebraham added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 79bbd67 Apr 8, 2025
39 checks passed
@bugadani bugadani deleted the mmu-page-size branch April 8, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[esp32c6] espflash save-image converts the ELF image to a .bin which has the DROM/IROM segment containing esp_app_desc_t at a wrong position
2 participants
@bugadani @jessebraham